Skip to content

[SRVKS-1301] Update knative/operator to fix webhook creation issues#3561

Closed
dsimansk wants to merge 1 commit intoopenshift-knative:mainfrom
dsimansk:pr/main-update-knative-operator
Closed

[SRVKS-1301] Update knative/operator to fix webhook creation issues#3561
dsimansk wants to merge 1 commit intoopenshift-knative:mainfrom
dsimansk:pr/main-update-knative-operator

Conversation

@dsimansk
Copy link
Copy Markdown
Contributor

@dsimansk dsimansk commented Mar 19, 2025 •
edited
Loading

Fixes JIRA SRVKS-1301

Proposed Changes

  • [SRVKS-1301] Update knative/operator to fix webhook creation issues

Produced with:

go get knative.dev/operator@release-1.16
./hack/update-deps.sh

/cc @matzew @pierDipi

@openshift-ci openshift-ci Bot requested review from matzew and pierDipi March 19, 2025 16:56
@matzew
Copy link
Copy Markdown
Member

matzew commented Mar 20, 2025

/retest-required

2 similar comments
@pierDipi
Copy link
Copy Markdown
Member

pierDipi commented Mar 21, 2025

/retest-required

@dsimansk
Copy link
Copy Markdown
Contributor Author

dsimansk commented Mar 25, 2025

/retest-required

@dsimansk
Copy link
Copy Markdown
Contributor Author

dsimansk commented Mar 26, 2025

/retest

@matzew
Copy link
Copy Markdown
Member

matzew commented Mar 27, 2025

/retest-required

matzew
matzew approved these changes Mar 27, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@matzew matzew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci openshift-ci Bot added the lgtm label Mar 27, 2025
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Mar 27, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dsimansk, matzew

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@matzew
Copy link
Copy Markdown
Member

matzew commented Mar 27, 2025

/test serverless-metadata-webhook-136-on-pull-request

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Mar 27, 2025

@matzew: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

/test 414-images

/test 414-operator-e2e

/test 414-test-upgrade

/test 417-aws-ovn-images

/test 417-azure-images

/test 417-gcp-images

/test 417-hypershift-images

/test 417-images

/test 417-operator-e2e

/test 417-osd-images

/test 417-single-node-images

/test 417-test-upgrade

/test 417-vsphere-images

/test 418-images

/test 418-operator-e2e

/test 418-test-upgrade

/test ocp4.17-lp-rosa-classic-images

/test ocp4.18-lp-interop-images

The following commands are available to trigger optional jobs:

/test 414-kitchensink-e2e

/test 414-kitchensink-upgrade

/test 414-mesh-e2e

/test 414-mesh-upgrade

/test 414-test-soak

/test 414-ui-e2e

/test 414-upstream-e2e

/test 414-upstream-e2e-kafka

/test 417-kitchensink-e2e

/test 417-kitchensink-upgrade

/test 417-mesh-e2e

/test 417-mesh-upgrade

/test 417-test-soak

/test 417-ui-e2e

/test 417-upstream-e2e

/test 417-upstream-e2e-kafka

/test 418-kitchensink-e2e

/test 418-kitchensink-upgrade

/test 418-mesh-e2e

/test 418-mesh-upgrade

/test 418-test-soak

/test 418-ui-e2e

/test 418-upstream-e2e

/test 418-upstream-e2e-kafka

Use /test all to run the following jobs that were automatically triggered:

pull-ci-openshift-knative-serverless-operator-main-417-aws-ovn-images

pull-ci-openshift-knative-serverless-operator-main-417-azure-images

pull-ci-openshift-knative-serverless-operator-main-417-gcp-images

pull-ci-openshift-knative-serverless-operator-main-417-hypershift-images

pull-ci-openshift-knative-serverless-operator-main-417-images

pull-ci-openshift-knative-serverless-operator-main-417-operator-e2e

pull-ci-openshift-knative-serverless-operator-main-417-osd-images

pull-ci-openshift-knative-serverless-operator-main-417-single-node-images

pull-ci-openshift-knative-serverless-operator-main-417-test-upgrade

pull-ci-openshift-knative-serverless-operator-main-417-upstream-e2e

pull-ci-openshift-knative-serverless-operator-main-417-upstream-e2e-kafka

pull-ci-openshift-knative-serverless-operator-main-417-vsphere-images

pull-ci-openshift-knative-serverless-operator-main-ocp4.17-lp-rosa-classic-images

pull-ci-openshift-knative-serverless-operator-main-ocp4.18-lp-interop-images
Details

In response to this:

/test serverless-metadata-webhook-136-on-pull-request

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Mar 27, 2025

/retest-required

Remaining retests: 0 against base HEAD 256980a and 2 for PR HEAD d822733 in total

@matzew
Copy link
Copy Markdown
Member

matzew commented Mar 28, 2025

/test 417-operator-e2e

@matzew
Copy link
Copy Markdown
Member

matzew commented Mar 28, 2025

/test serverless-metadata-webhook-136-on-pull-request

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Mar 28, 2025

@matzew: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

/test 414-images

/test 414-operator-e2e

/test 414-test-upgrade

/test 417-aws-ovn-images

/test 417-azure-images

/test 417-gcp-images

/test 417-hypershift-images

/test 417-images

/test 417-operator-e2e

/test 417-osd-images

/test 417-single-node-images

/test 417-test-upgrade

/test 417-vsphere-images

/test 418-images

/test 418-operator-e2e

/test 418-test-upgrade

/test ocp4.17-lp-rosa-classic-images

/test ocp4.18-lp-interop-images

The following commands are available to trigger optional jobs:

/test 414-kitchensink-e2e

/test 414-kitchensink-upgrade

/test 414-mesh-e2e

/test 414-mesh-upgrade

/test 414-test-soak

/test 414-ui-e2e

/test 414-upstream-e2e

/test 414-upstream-e2e-kafka

/test 417-kitchensink-e2e

/test 417-kitchensink-upgrade

/test 417-mesh-e2e

/test 417-mesh-upgrade

/test 417-test-soak

/test 417-ui-e2e

/test 417-upstream-e2e

/test 417-upstream-e2e-kafka

/test 418-kitchensink-e2e

/test 418-kitchensink-upgrade

/test 418-mesh-e2e

/test 418-mesh-upgrade

/test 418-test-soak

/test 418-ui-e2e

/test 418-upstream-e2e

/test 418-upstream-e2e-kafka

Use /test all to run the following jobs that were automatically triggered:

pull-ci-openshift-knative-serverless-operator-main-417-aws-ovn-images

pull-ci-openshift-knative-serverless-operator-main-417-azure-images

pull-ci-openshift-knative-serverless-operator-main-417-gcp-images

pull-ci-openshift-knative-serverless-operator-main-417-hypershift-images

pull-ci-openshift-knative-serverless-operator-main-417-images

pull-ci-openshift-knative-serverless-operator-main-417-operator-e2e

pull-ci-openshift-knative-serverless-operator-main-417-osd-images

pull-ci-openshift-knative-serverless-operator-main-417-single-node-images

pull-ci-openshift-knative-serverless-operator-main-417-test-upgrade

pull-ci-openshift-knative-serverless-operator-main-417-upstream-e2e

pull-ci-openshift-knative-serverless-operator-main-417-upstream-e2e-kafka

pull-ci-openshift-knative-serverless-operator-main-417-vsphere-images

pull-ci-openshift-knative-serverless-operator-main-ocp4.17-lp-rosa-classic-images

pull-ci-openshift-knative-serverless-operator-main-ocp4.18-lp-interop-images
Details

In response to this:

/test serverless-metadata-webhook-136-on-pull-request

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@matzew
Copy link
Copy Markdown
Member

matzew commented Mar 28, 2025

/test 417-operator-e2e

@dsimansk
Copy link
Copy Markdown
Contributor Author

dsimansk commented Mar 28, 2025

/test 417-upstream-e2e

@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Mar 28, 2025

/retest-required

Remaining retests: 0 against base HEAD 256980a and 2 for PR HEAD d822733 in total

@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Mar 28, 2025

/retest-required

Remaining retests: 0 against base HEAD 4be7c24 and 1 for PR HEAD d822733 in total

@matzew
Copy link
Copy Markdown
Member

matzew commented Mar 28, 2025

/test 417-operator-e2e

@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Mar 28, 2025

/retest-required

Remaining retests: 0 against base HEAD 4be7c24 and 2 for PR HEAD d822733 in total

5 similar comments
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Mar 31, 2025

/retest-required

Remaining retests: 0 against base HEAD 4be7c24 and 2 for PR HEAD d822733 in total

@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Mar 31, 2025

/retest-required

Remaining retests: 0 against base HEAD 4be7c24 and 2 for PR HEAD d822733 in total

@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Apr 1, 2025

/retest-required

Remaining retests: 0 against base HEAD 4be7c24 and 2 for PR HEAD d822733 in total

@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Apr 1, 2025

/retest-required

Remaining retests: 0 against base HEAD 4be7c24 and 2 for PR HEAD d822733 in total

@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Apr 1, 2025

/retest-required

Remaining retests: 0 against base HEAD 4be7c24 and 2 for PR HEAD d822733 in total

@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Apr 2, 2025

/retest-required

Remaining retests: 0 against base HEAD 4be7c24 and 2 for PR HEAD d822733 in total

11 similar comments
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Apr 2, 2025

/retest-required

Remaining retests: 0 against base HEAD 4be7c24 and 2 for PR HEAD d822733 in total

@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Apr 2, 2025

/retest-required

Remaining retests: 0 against base HEAD 4be7c24 and 2 for PR HEAD d822733 in total

@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Apr 3, 2025

/retest-required

Remaining retests: 0 against base HEAD 4be7c24 and 2 for PR HEAD d822733 in total

@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Apr 3, 2025

/retest-required

Remaining retests: 0 against base HEAD 4be7c24 and 2 for PR HEAD d822733 in total

@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Apr 3, 2025

/retest-required

Remaining retests: 0 against base HEAD 4be7c24 and 2 for PR HEAD d822733 in total

@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Apr 3, 2025

/retest-required

Remaining retests: 0 against base HEAD 4be7c24 and 2 for PR HEAD d822733 in total

@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Apr 4, 2025

/retest-required

Remaining retests: 0 against base HEAD 4be7c24 and 2 for PR HEAD d822733 in total

@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Apr 4, 2025

/retest-required

Remaining retests: 0 against base HEAD 4be7c24 and 2 for PR HEAD d822733 in total

@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Apr 5, 2025

/retest-required

Remaining retests: 0 against base HEAD 4be7c24 and 2 for PR HEAD d822733 in total

@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Apr 5, 2025

/retest-required

Remaining retests: 0 against base HEAD 4be7c24 and 2 for PR HEAD d822733 in total

@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Apr 7, 2025

/retest-required

Remaining retests: 0 against base HEAD 4be7c24 and 2 for PR HEAD d822733 in total

@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Apr 8, 2025

/retest-required

Remaining retests: 0 against base HEAD 78b3845 and 1 for PR HEAD d822733 in total

@Kaustubh-pande
Copy link
Copy Markdown
Contributor

Kaustubh-pande commented Apr 8, 2025

/ok-to-test

@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Apr 8, 2025

/retest-required

Remaining retests: 0 against base HEAD 78b3845 and 2 for PR HEAD d822733 in total

1 similar comment
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Apr 8, 2025

/retest-required

Remaining retests: 0 against base HEAD 78b3845 and 2 for PR HEAD d822733 in total

@Kaustubh-pande
Copy link
Copy Markdown
Contributor

Kaustubh-pande commented Apr 9, 2025

/retest-required

@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Apr 9, 2025

/retest-required

Remaining retests: 0 against base HEAD 78b3845 and 2 for PR HEAD d822733 in total

@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Apr 9, 2025

/retest-required

Remaining retests: 0 against base HEAD 216bc6d and 1 for PR HEAD d822733 in total

@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Apr 10, 2025

/retest-required

Remaining retests: 0 against base HEAD 087e0ce and 0 for PR HEAD d822733 in total

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Apr 10, 2025

@dsimansk: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/417-upstream-e2e-kafka d822733 link false /test 417-upstream-e2e-kafka
ci/prow/417-upstream-e2e d822733 link false /test 417-upstream-e2e
ci/prow/417-operator-e2e d822733 link true /test 417-operator-e2e

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Apr 10, 2025

/hold

Revision d822733 was retested 3 times: holding

@openshift-merge-robot
Copy link
Copy Markdown
Contributor

openshift-merge-robot commented Apr 23, 2025

PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@dsimansk
Copy link
Copy Markdown
Contributor Author

dsimansk commented May 7, 2025

Superseded by #3602

@dsimansk
Copy link
Copy Markdown
Contributor Author

dsimansk commented May 7, 2025

/close

@openshift-ci openshift-ci Bot closed this May 7, 2025
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 7, 2025

@dsimansk: Closed this PR.

Details

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@matzew matzew matzew approved these changes

@pierDipi pierDipi Awaiting requested review from pierDipi

Assignees

@matzew matzew

Labels

approved do-not-merge/hold lgtm needs-rebase ok-to-test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@dsimansk @matzew @pierDipi @openshift-ci-robot @Kaustubh-pande @openshift-merge-robot